-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Upgrade sandboxes to 19.2 #8037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Five Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
@gaearon I'm not getting 15.2 to work locally either. Could it be a bug in the lib instead of sandpack? Exploring the |
No, 19.2 itself should work fine: https://codesandbox.io/p/sandbox/36zsm3 |
Yes, it works as expected: sandbox fork |
Filed codesandbox/sandpack-cdn#43 for possible root cause, idk what's wrong though |
Please create a reproducing project, this is not necessarily related. Next includes a vendor copy of React so it might not have caught up with 19.2 yet. |
Here's a minimal repo to reproduce the issue in Next latest: https://github.com/webbertakken/repro-react-19-2-element-type-undefined If I had to guess, I'd say it might have something to do with how some bundlers handle the exported Symbols. |
Looking into this! |
@webbertakken I'm hearing from Next people that this is expected because Next hasn't done a stable release with 19.2 yet. It should work on canary. Next vendors its own copy of React so the versions in |
Cool, thanks! Looks like on the dev website it's also working now. |
I found the issue on our side. Due to an upgrade to the npm couchdb instance (https://github.com/orgs/community/discussions/152515) our npm registry replicator for sandpack cdn (which resolves dependency versions) does not completely sync anymore. Because of this, we cannot resolve semvers properly. I am writing a fix now. |
Fantastic, thank you so much! |
Wrote a fix, the CDN is syncing now, I will make sure that it downloads new metadata in parallel to go faster. I will have an update on how long it'll take soon. |
* Fix Activity sandboxes * hacky fix
This reverts commit f9fd07c.
Okay, it works now! Manually synced Both existing (live examples) and the 19.2.0 references (this PR) now work. |
Thanks @CompuIves!!! Ok this is good to go, I needed to revert some of the |
I did find one (existing) issue on the escape hatches page: #8045 |
Sandpack is just broken for some reason